[bug 882944] Stop showing empty subtopics.#1437
Conversation
Swithed to use our existing topics_for() helper for listing subtopics.
|
nevermind R+! woot |
|
oh no wrong PR lol |
|
r- @rlr r- |
kitsune/wiki/facets.py
Outdated
There was a problem hiding this comment.
I think this change to the signature is a little odd because the parent and include_subtopics parameters are really interconnected. It doesn't make a lot of sense to speicify both, but there is nothing stopping you. Sadly I can't think of a way to improve this.
There was a problem hiding this comment.
Maybe default parent to False? and set it if it isn't False. Then kill include_subtopics?
There was a problem hiding this comment.
Oh, that makes sense. I was trying to think of something like that and getting caught up because my usual null value, None, was already a thing.
|
ok, i like that better ^^ |
|
Nice! 😀 r+ |
Swithed to use our existing topics_for() helper for listing subtopics.
r?